> Is this patch going to screw my kernel up?
I hope not. I've been testing it both on systems with PCI bus and with
just ISA/VLB. I've also done all=1 testing on various PCI systems which
then correctly work with legacy IDE although performance of course sucks
rocks.
On most boxes the code path executed is
have we got PCI ata
yes
exit
>
> > +static __init void probe_opti_vlb(void)
> > +{
> > + /* If an OPTI 82C46X is present find out where the channels are */
> > + static const char *optis[4] = {
> > + "3/463MV", "5MV",
> > + "5MVA", "5MVB"
> > + };
> > + u8 chans = 1;
> > + u8 ctrl = (opti_syscfg(0x30) & 0xC0) >> 6;
> > +
> > + opti82c46x = 3; /* Assume master and slave first */
> > + printk(KERN_INFO DRV_NAME ": Opti 82C46%s chipset support.\n",
> > + optis[ctrl]);
> > + if (ctrl == 3)
> > + chans = (opti_syscfg(0x3F) & 0x20) ? 2 : 1;
>
> this could be
>
> if (ctrl == 3 && (opti_syscfg(0x3F) & 0x20))
> chans = 2;
>
> if that's any clearer...
Agreed - that is clearer.
Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
