Re: [PATCH 3/20] dtc2278: ->io_32bit setting don't have to be identical for master/slave

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 10 Dec 2007 00:52:28 +0100
Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote:

> On Monday 10 December 2007, Alan Cox wrote:
> > > There is absolutely no hardware setup done by IDE subsystem or dtc2278
> > > host driver when ->io_32bit setting is changed and since ->io_32bit setting
> > 
> > So ?
> > 
> > The original author went to great trouble to specifically enforce the
> > behaviour in question and probably did so for a reason. Would it not be
> 
> Probably so but please keep in mind the state of IDE subsystem back
> then...
> 
> > far safer to fix it by keeping that enforcement and fixing where it is
> > lost than removing it - especially if you cannot test the hardware ?
> 
> What about just enforcing ->io_32bit for both drives in ->init_hwif method
> and disallowing any futher changes with 'hwif->no_io_32bit = 1'?

Sounds fine to me. 

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux