Re: [PATCH 14/14] libata: use PIO for misc ATAPI commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Petr Vandrovec wrote:
> Alan Cox wrote:
>>> It eventually has to end up in -rc.  If not for 2.6.25-rc1 is too early,
>>> we can put it in #testing and put it into #upstream later.
>>
>> Nobody cares about libata git trees. If you want some initial test
>> coverage put it in -mm.
>>
>>> primarily worried about.  Command type dependent quick fallback might
>>> help but ancient controllers are more likely to bring the whole machine
>>> down when a DMA transaction goes south.
>>
>> Quite the reverse in my experience - the dumber the controller the more
>> likely that ATAPI DMA and LBA48 and other stuff just works anyway.
> 
> Yes.  FYI, if you'll start sending ATAPI commands with DATA_OUT phase
> using PIO from VM under VMware, it will politely ask you to reconfigure
> OS in the virtual machine to use DMA, and most probably it won't work
> until you really do so...  Windows are sending all these commands using
> DMA, and I believe they do same for majority of DATA_IN commands as well
> (and Windows also set byte count to correct PIO-like value even for DMA
> commands)

There are few DATA OUT commands and most of them are sector (2k)
aligned.  We use DMA for them.  The same goes for sector aligned DATA IN
commands and READ CD but what you say is inconsistent with what I've
seen from SATA bus trace.  Windows was using PIO for all misc DATA IN
commands - such as REQUEST SENSE, GET CONFIGURATION, MODE SENSE, etc...

And, libata will set byte count to PIO-like value for DMA from 2.6.25 if
not from 24.

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux