Jeff Garzik wrote:
> Tejun Heo wrote:
>> While updating lbam/h for ATAPI commands, atapi_eh_request_sense() was
>> left out. Update it.
>>
>> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
>> ---
>> drivers/ata/libata-eh.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
>> index 77083b5..2e3d3a2 100644
>> --- a/drivers/ata/libata-eh.c
>> +++ b/drivers/ata/libata-eh.c
>> @@ -1302,8 +1302,8 @@ static unsigned int
>> atapi_eh_request_sense(struct ata_queued_cmd *qc)
>> tf.feature |= ATAPI_PKT_DMA;
>> } else {
>> tf.protocol = ATA_PROT_ATAPI;
>> - tf.lbam = (8 * 1024) & 0xff;
>> - tf.lbah = (8 * 1024) >> 8;
>> + tf.lbam = SCSI_SENSE_BUFFERSIZE;
>> + tf.lbah = 0;
>
> seems like #upstream-fixes material?
I'm not too sure yet whether we'll need to revert ATAPI transfer chunk
size change for #upstream-fixes or not. It fixes some cases while
breaking others. Dunno which side is larger but we definitely don't
wanna regress in a released kernel. I thought adding full chunk
draining would fix regressions but apparently not. Fortunately, with
full ATAPI data transfer improvement patch applied, it works. I'll
investigate more.
Thanks.
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
