Hi, On Tue, Dec 04, 2007 at 08:07:26PM +0300, Anton Vorontsov wrote: > diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts > index 5072f6d..c459b0a 100644 > --- a/arch/powerpc/boot/dts/mpc8349emitx.dts > +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts > @@ -249,6 +249,22 @@ > device_type = "pci"; > }; > > + localbus@e0005000 { > + #address-cells = <2>; > + #size-cells = <1>; > + compatible = "fsl,mpc8349emitx-localbus", > + "fsl,mpc8349e-localbus", > + "fsl,pq2pro-localbus"; > + reg = <e0005000 d8>; > + ranges = <3 0 f0000000 210>; > > - > + pata@3,0 { What's the ,0 for? > + compatible = "fsl,mpc8349emitx-pata", "ata-generic"; > + reg = <3 0 10 3 20c 4>; > + reg-shift = <1>; > + pio-mode = <6>; > + interrupts = <17 8>; > + interrupt-parent = <&ipic>; > + }; > + }; > }; > diff --git a/arch/powerpc/platforms/83xx/mpc834x_itx.c b/arch/powerpc/platforms/83xx/mpc834x_itx.c > index aa76819..ea5f176 100644 > --- a/arch/powerpc/platforms/83xx/mpc834x_itx.c > +++ b/arch/powerpc/platforms/83xx/mpc834x_itx.c > @@ -23,6 +23,7 @@ > #include <linux/delay.h> > #include <linux/seq_file.h> > #include <linux/root_dev.h> > +#include <linux/of_platform.h> > > #include <asm/system.h> > #include <asm/atomic.h> > @@ -37,6 +38,22 @@ > > #include "mpc83xx.h" > > +static struct of_device_id mpc834x_itx_ids[] = { > + { .name = "localbus", }, > + {}, > +}; Please add the "compatible" field here (fsl,pq2pro-localbus should do just fine), instead of the name. (Sorry for not spotting this sooner) -Olof - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html