Hi, On Monday 03 December 2007, Kiyoshi Ueda wrote: [...] > Thank you for the comments. > I rebased my patch on top of 2.6.24-rc3-mm2 + the patch to remove > post_transform_command(). > > As a result, one callback function for DMA mode has been removed. > What do you think about the patch below? > > > > Subject: [PATCH 26/28] blk_end_request: changing ide-cd (take 3) > > > This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request > interfaces. > > In PIO mode, ide-cd (cdrom_newpc_intr()) needs to defer > end_that_request_last() until the device clears DRQ_STAT and raises > an interrupt after end_that_request_first(). > So blk_end_request() has to return without completing request > even if no leftover in the request. > > ide-cd uses blk_end_request_callback() and a dummy callback function, > which just returns value '1', to tell blk_end_request_callback() > about that. > > Signed-off-by: Kiyoshi Ueda <k-ueda@xxxxxxxxxxxxx> > Signed-off-by: Jun'ichi Nomura <j-nomura@xxxxxxxxxxxxx> Looks good, thanks! Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
