Bartlomiej Zolnierkiewicz wrote:
This belongs to user-space (and only if really needed).
Sigh, and why only I spent time fixing this code? :-)
text data bss dec hex filename 3874 180 28 4082 ff2 drivers/ide/pci/cmd64x.o.before 2231 180 0 2411 96b drivers/ide/pci/cmd64x.o.after
Additionaly to being bloat the code contained two bugs: - incorrect UDMA modes were reported for reserved values of UDIDETCR0/1 regs
Huh? What reserved values?
- MRDMODE_BLK_CH0/1 bits are not defined on CMD643 and early CMD646 revisions
They're 0 there anyway, so the code worked properly.
Also while at it remove unused CNTRL_DIS_RA0/1 defines.
Cc: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html