Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark Lord wrote:
Mark Lord wrote:
Alan Cox wrote:
Confirmed.  It writes "lgcy" + stuff into the 9th sector of the drive
(for my "Legacy" drive).

Thats quite nasty. Given that users putting volumes unpartitioned on
drives may see actual data corruption and loss perhaps we should
blacklist that controller variant with a large warning ?
..

Yeah, that's quite obnoxious of Highpoint to just arbitrarily overwrite data.

Some warnings would probably be quite useful here.

We could log a WARNING the first few times (after boot)
whenever we see software writing to that sector.
Do this with a hack in mv_qc_prep or mv_qc_issue ?

Or even just fail any write to that sector, so that the error
gets propagated all the way back to usermode where it might be visible?

Plus some big nasty "awareness" messages at boot regardless.
...

Something like this, perhaps.

Comments, suggestions ?
..

I'm not convinced that the big sledgehammer (previous patch which snooped
for access to the sector that sometimes is overwritten by BIOS)
is useful or does any good here.

The problem is, just by powering-on with a drive connected to the RocketRAID,
one may have already toasted that sector, long before Linux/sata_mv ever
get to see it or warn about it.

So, at a minimum, we do need to print some kind of disclaimer message
to show that we're at least aware of it.

But beyond that, I don't think there's anything *really* useful to do.
Comments?

I'll cook up a patch for 2.6.24 that detects and warns when a PCIe
RocketRAID is found.
But do *all* HighPoint "RAID" cards do the same thing?
Anyone out there got hardware other than a 2300/2310 ?

Thanks
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux