On Sat, 01 Dec 2007 18:23:44 -0500, Jeff Garzik wrote: > Tejun Heo wrote: > > Make pdc_atapi_pkt() use values from qc->tf instead of creating its > > own. This is to ease future ATAPI handling changes. > > > > DONT APPLY YET > > --- > > Mikael, would this work? Values other than lbam and lbah remain the > > same. Does sata_promise have strict requirements for lbam and lbah? > > > > Thanks. > > > > drivers/ata/sata_promise.c | 34 +++++++++++++--------------------- > > 1 file changed, 13 insertions(+), 21 deletions(-) > > what was the outcome of this discussion? > > I haven't looked over the Promise datasheet nor checked my brain for > details, hoping Mikael would do that for me ;-) I've now tested this on top of 2.6.24-rc3, with no observable regressions. Blanking, writing, and mounting/reading CD-RWs on both SATAPI and PATAPI works (tested on a 300 TX2plus card). I can't find anything in Promise's public docs or reference driver about non-standard requirements on lbam/lbah in ATAPI packets. /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
