Tejun Heo wrote:
ata_id_to_dma_mode() isn't quite generic. The function is basically
privately implemented ata_id_xfermask() combined with hardcoded mode
printing and configuration which are specific to ata_generic.
Kill the function and open code it in generic_set_mode() using generic
xfermode handling functions.
Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
[responding to Alan's objection, and subsequent thread]
Yeah, it's a matter of taste. I applied, figuring "in for a dime in for
a dozen" :)
I'm not thrilled with all these fine-grained exports of timing tables
and mode mask functions.
I applied the patches, but I would really like to hide more of these
details away from LLD [if possible, the obvious disclaimed...]
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
