On Tue, 27 Nov 2007 19:43:41 +0900 Tejun Heo <htejun@xxxxxxxxx> wrote: > ata_id_to_dma_mode() isn't quite generic. The function is basically > privately implemented ata_id_xfermask() combined with hardcoded mode > printing and configuration which are specific to ata_generic. > > Kill the function and open code it in generic_set_mode() using generic > xfermode handling functions. That one I still think is a bad idea. This sort of internal knowledge belongs in library routines. It is a pretty generic function for the case where the device is using existing modes and wants to display them. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
