On Monday 19 November 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Move ETRAX_IDE and friends from arch/cris/arch-{v10,v32}/drivers/Kconfig
> > to drivers/ide/Kconfig.
>
> > * Don't force selecting ide-disk and ide-cd device drivers
> > (please handle this through defconfig if necessary).
>
> > * Make ETRAX_IDE depend on BROKEN for the time being
> > (it doesn't even compile currently).
>
> > Cc: Mikael Starvik <starvik@xxxxxxxx>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
>
> > Index: b/drivers/ide/Kconfig
> > ===================================================================
> > --- a/drivers/ide/Kconfig
> > +++ b/drivers/ide/Kconfig
> > @@ -870,6 +870,41 @@ config BLK_DEV_IDE_BAST
> > Say Y here if you want to support the onboard IDE channels on the
> > Simtec BAST or the Thorcom VR1000
> >
> > +config ETRAX_IDE
> > + bool "ETRAX IDE support"
> > + depends on CRIS && BROKEN
> > + select BLK_DEV_IDEDMA
>
> Shouldn't it be the other way around, i.e. BLK_DEV_IDEDMA is enabled by
> ETRAX_IDE as is the case with this option otherwise?
Well, having a simple
config BLK_DEV_IDEDMA
bool
and making the other options select it seems to be a better solution.
Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
