Mark Lord wrote: > Tejun Heo wrote: >> Robert Hancock wrote: >>> Tejun Heo wrote: > .. >>> Yes, it should likely do something with these return values. Though >>> theoretically it shouldn't fail, since the DMA mask is either 32-bit, >>> which shouldn't fail, or one that was successfully set before. Also I >>> don't think the SCSI layer actually checks the slave_config return >>> value.. sigh. >> >> Then please at least add WARN_ON() && another reason why allocating / >> deallocating resources from ->slave_config isn't such a good idea. > .. > > The entire point of "slave_configure" is to provide a point for the LLD > to do per-device data structure allocation/init. > > And yes, SCSI does check the return code. Whether the code around that > check > is buggy or not is another question, but it's always worked for me. I see but I still prefer having PRD, pad buf allocation/release in ->port_start/stop() primarily for consistency. Robert, what do you think? -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
