Re: [PATCH 12/13] ide: move drive->using_dma check to callers of ->dma_host_on method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 13 November 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
> 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> 
> Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
> 
> MBR, Sergei
> 
> > Index: b/drivers/ide/ide-dma.c
> > ===================================================================
> > --- a/drivers/ide/ide-dma.c
> > +++ b/drivers/ide/ide-dma.c
> > @@ -470,7 +470,7 @@ EXPORT_SYMBOL(ide_dma_off);
> >  
> >  void ide_dma_host_on(ide_drive_t *drive)
> >  {
> > -	if (drive->using_dma) {
> > +	if (1) {
> 
>     Why so?

Just not to move the code around (because it "vanishes" in patch #13/13).

> >  		ide_hwif_t *hwif	= HWIF(drive);
> >  		u8 unit			= (drive->select.b.unit & 0x01);
> >  		u8 dma_stat		= hwif->INB(hwif->dma_status);
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux