sata_qstor fix oops on rmmod.
sata_qstor likes to disable the chip on module unload,
so it provides a libata "host_stop" method to do this.
But in recent kernels, this routine is now called too late,
after the PCI mmio resources have already been released.
Which produces an oops.
This really needs to be fixed higher up.
For an interim workaround, we disable this function for now.
This belongs in 2.6.24.
Signed-off-by: Mark Lord <mlord@xxxxxxxxx>
---
--- old/drivers/ata/sata_qstor.c 2007-10-12 12:43:44.000000000 -0400
+++ linux/drivers/ata/sata_qstor.c 2007-11-06 22:32:34.000000000 -0500
@@ -523,10 +523,20 @@
static void qs_host_stop(struct ata_host *host)
{
+#if 0
+ /*
+ * This code used to work, but now segfaults
+ * because we get called *after* our mmio resources
+ * have already been unmapped. That's probably a bug
+ * in an upper layer somewhere, so this code has been
+ * disabled (but left in place) until it gets tracked
+ * down properly.
+ */
void __iomem *mmio_base = qs_mmio_base(host);
writeb(0, mmio_base + QS_HCT_CTRL); /* disable host interrupts */
writeb(QS_CNFG3_GSRST, mmio_base + QS_HCF_CNFG3); /* global reset */
+#endif
}
static void qs_host_init(struct ata_host *host, unsigned int chip_id)
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
