> > + if (chip_table == &hpt374) { > > + freq = hpt374_read_freq(dev); > > + if (freq == 0) > > + return -ENODEV; > > Not sure whether this check is necessary... If the device is hot unplugged we can get a zero return error case. It seems cleaner to catch the error case rather than attempt to prove it does no harm later. pre_reset one fixed in my tree and will check and push. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html