On Tue, 6 Nov 2007 14:39:06 +0900 Tejun Heo <htejun@xxxxxxxxx> wrote: > libata-acpi is using separate timing tables for transfer modes > although libata-core has the complete ata_timing table. Implement > ata_timing_cycle2mode() to look for matching mode given transfer type > and cycle duration and use it in libata-acpi and pata_acpi to replace > private timing tables. Ok that makes sense having now seen the second chunk of patches. Just one problem: > + /* PIO */ > + mode = ata_timing_cycle2mode(ATA_SHIFT_PIO, gtm->drive[unit].pio); > + xfer_mask |= ata_xfer_mode2mask(mode); No check v 0xFF > + * ata_timing_cycle2mode - find xfer mode for the specified cycle duration > + * @xfer_shift: ATA_SHIFT_* value for transfer type to examine. > + * @cycle: cycle duration in ns > + * > + * Return matching xfer mode for @cycle. The returned mode is of > + * the transfer type specified by @xfer_shift. If @cycle is too > + * slow for @xfer_shift, 0xff is returned. If @cycle is faster > + * than the fastest known mode, the fasted m Can return 0xFF - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
