On Tue, 6 Nov 2007 14:39:03 +0900 Tejun Heo <htejun@xxxxxxxxx> wrote: > xfer_mask is unsigned int not unsigned long. Change ->mode_filter to > take and return unsigned int. > > While at it, rename @adev of ata_pci_default_filter() to @dev for > consistency. > > Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> The filter type was purposefully unsigned long to allow for expansion (eg for SWDMA) without breaking drivers. No problem with it changing but I'd say "unsigned int" was the worst possible choice - its now shorter (no room for expansion) and size dependant on arch. u32 would be shorter and consistent across all platforms, ulong would have more room for expansion. Alan - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
