Re: [PATCH] pata_hpt37x: Fix outstanding bug reports on the HPT374 and 37x cable detect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 5 Nov 2007 22:53:38 +0000 Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> +static u32 hpt374_read_freq(struct pci_dev *pdev)
> +{
> +	u32 freq;
> +	unsigned long io_base = pci_resource_start(pdev, 4);
> +	if (PCI_FUNC(pdev->devfn) & 1) {
> +		struct pci_dev *pdev_0 = pci_get_slot(pdev->bus, pdev->devfn - 1);
> +		/* Someone hot plugged the controller on us ? */
> +		if (pdev_0 == NULL)
> +			return 0;
> +		io_base = pci_resource_start(pdev_0, 4);
> +		freq = inl(io_base + 0x90);
> +		pci_dev_put(pdev_0);
> +	}
> +	else
> +		freq = inl(io_base + 0x90);
> +	return freq;
> +}

hm, pci_resource_start() returns a resource_size_t and I guess this (and a
heck of a lot of other) code is bust on (whatever machine we added that for).
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux