Re: [PATCH 2/3] libata: extend ata_acpi_cbl_80wire() and fix cable detection in pata_via and pata_amd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Cox wrote:
>> 2. UDMA mode is configured but equal to or under UDMA33.  Dunno whether
>> it's cable or device limit but anyways you better limit it to UDMA33 too.
> 
> If it is under UDMA33 you know it isn't a cable limit
> 
> If it is UDMA 33 and the device top is > UDMA 33 it might be
> 
> This matters as you've got to account for both master and slave, as well
> as hotplug in theory.

I'm not sure whether that level of sophistication is necessary here.
This is more like a transfer rate filter thing rather than actual cable
detection.  We're basically just trying to follow what BIOS did.  Maybe
we should return ATA_CBL_PATA_MAYBE_80 unconditionally and implement
ata_acpi_more_filter()?

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux