On Thu, 01 Nov 2007 05:54:06 -0400 Jeff Garzik <jeff@xxxxxxxxxx> wrote: > Alan Cox wrote: > > On Thu, 1 Nov 2007 05:07:33 -0400 > > Jeff Garzik <jeff@xxxxxxxxxx> wrote: > > > >> This is purely for comment and testing, not for merging (yet?). > >> > >> A common recipe in several vendor drivers (either GPL'd, or I have NDA'd > >> access to use them as a documentation-like reference) for ATAPI was > >> slightly different from ours. This recipe can be found in > >> atapi_tf_xfer_size(), and it's slightly different from Alan's. > > > > Looks mostly good. Might cause breakage on one or two controllers by > > setting lbam/lbah to 0 for DMA but we can test that and find out. > > DMA always zeroed lbam/lbah thanks to memset(), my patch merely made it > explicit. That would be a bug if so - need to try fixing that and see if it sorts out the remaining recalcitrant ALi chips. Alan - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html