Jeff Garzik wrote:
Mikael Pettersson wrote:
>> @@ -530,7 +608,7 @@ static void pdc_qc_prep(struct ata_queue
switch (qc->tf.protocol) {case ATA_PROT_DMA: - ata_qc_prep(qc); + pdc_fill_sg(qc); /* fall through */case ATA_PROT_NODATA:@@ -546,11 +624,11 @@ static void pdc_qc_prep(struct ata_queue break;case ATA_PROT_ATAPI:- ata_qc_prep(qc); + pdc_fill_sg(qc); break;case ATA_PROT_ATAPI_DMA:- ata_qc_prep(qc); + pdc_fill_sg(qc); /*FALLTHROUGH*/Note that this is not exactly an equivalent change -- you are removing the test in ata_qc_prep() that occurs prior to ata_fill_sg() call.
Not at all. The test is there at the beginning of pdc_fill_sg(). -- ./lxnt - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
