Andrew wrote: > > On Thu, October 25, 2007 13:11, Bartlomiej Zolnierkiewicz wrote: > > > > > > a better version > > > > [PATCH] sata_nv: respect swncq_enabled setting > > > > > > SWNCQ is always used despite swncq_enabled setting (which > is disabled by > > default). Fix it by using GENERIC nv_port_info[] entry for > SWNCQ controllers if swncq_enabled > > is not enabled. > > > > This patch worked a treat, thanks. > > - > Andrew > > I just reviewed your mails and simply analysed the message from http://andotnet.nfshost.com/linux/2.6.24-rc1-swncq.txt. I saw that the "Using SWNCQ mode" didn't appear, so the swncq should be equal to 0 and nv_swncq_host_init wasnt' called. >From the message "ata1.00: 976773168 sectors, multi 16: LBA48 NCQ (depth 31/32) " , i know the libata layer should use ncq protocol. Because the nv_port_info set ATA_FLAG_NCQ flag and the sata support ncq, ata_dev_config_ncq will set dev->flags |= ATA_DFLAG_NCQ and print (depth 31/32); When a ncq command is transferred to sata_nv, sata_nv with mcp51 in SWNCQ will handle it using ncq software flow whatever value the swncq is. The error maybe happens if sata_nv does ncq , but the nv_swncq_host_init isn't called and bios either doesn't initialize the ncq register. Best regards, Kuan Luo ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
