On Thu, 25 Oct 2007 14:21:16 +0100 Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote: > + if (print_info) { > + ata_dev_printk(dev, KERN_WARNING, > +"Drive reports diagnostics failure. This may indicate a drive\n"); > + ata_dev_printk(dev, KERN_WARNING, > +"fault or invalid emulation. Contact drive vendor for information.\n"); > + } eww, my eyes. It would be better to remove the first \n and use KERN_CONT in the second printk. Maybe. Even better would be to do it all in one printk so that it is atomic in the printk buffer. But you probably have more important things to be thinking about ;) - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html