On Thursday 18 October 2007, Benjamin Herrenschmidt wrote:
> The cs5535 use an incorrect construct to access the other drive
> of a pair, causing it to access beyond an array boundary on non-0
> interfaces. This fixes it by using the new ide_get_paired_drive()
> hepler instead.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
applied with patch description fixes
> ---
>
> drivers/ide/pci/cs5535.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-work/drivers/ide/pci/cs5535.c
> ===================================================================
> --- linux-work.orig/drivers/ide/pci/cs5535.c 2007-10-18 10:43:39.000000000 +1000
> +++ linux-work/drivers/ide/pci/cs5535.c 2007-10-18 10:44:00.000000000 +1000
> @@ -84,7 +84,7 @@ static void cs5535_set_speed(ide_drive_t
>
> /* Set the PIO timings */
> if ((speed & XFER_MODE) == XFER_PIO) {
> - ide_drive_t *pair = &drive->hwif->drives[drive->dn ^ 1];
> + ide_drive_t *pair = ide_get_paired_drive(drive);
> u8 cmd, pioa;
>
> cmd = pioa = speed - XFER_PIO_0;
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
