On Sunday 14 October 2007, Benjamin Herrenschmidt wrote: > > > How's about this patch? > > > > [PATCH] ide-pmac: fix pmac_ide_init_hwif_ports() > > > > * pmac_ide_init_hwif_ports() can be called by ide_init_hwif_ports() > > (through ppc_ide_md.ide_init_hwif hook) for non IDE PMAC interfaces. > > If this is the case the hw->io_ports[] should be already setup by > > ide_init_hwif_ports()->ide_std_init_ports() so remove redundant code > > from pmac_ide_init_hwif_ports(). > > > > As side-effect this change fixes ctl_addr == 0 special handling in > > ide_init_hwif_ports(). > > > > * Fix misleading comment while at it. > > I would have to try it. Problem is, I don't actually have any powermac > with a PCI IDE controller at hand.. ouch. I'll see what I can find. Same problem here, would be great if somebody with PMAC could test this patch (should apply cleanly to Linus' tree). Well, since the change is pretty safe I'm adding the patch to IDE tree (so it hopefully gets tested through -mm). Thanks, Bart - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
