Re: [PATCH] pata_cs5536: ATA driver for Geode companion chip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Long story short -- this has nothing to do with pata_cs5536.

It isn't in that list! I just patched my kernel to print the reason
why it is being blacklisted and this turned up:

ata5.00: ATA-0: , 060729DA, max MWDMA2
ata5.00: 256000 sectors, multi 1: LBA
ata5.00: device is on DMA blacklist, disabling DMA
ata5.00: device matched DMA blacklist, model: WDC AC11000H
ata5.00: configured for PIO4

The strn_pattern_cmp function does not handle blank model names. I
would like to give this Taiwanese manufacturer a bug for not bothering
to put a model name on their device, but I don't think they'll care
too much.. :)

I just submitted a patch to fix strn_pattern_cmp to handle the
strlen(name)==0 case appropriately (ie only match it against "*" or
"").

With that change, it is properly detected as MWDMA2 again:

ata5.00: ATA-0: , 060729DA, max MWDMA2
ata5.00: 256000 sectors, multi 1: LBA
ata5.00: configured for MWDMA2
ata5.00: configured for MWDMA2

Thanks,
-Andrew

On 10/14/07, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> On Sun, 14 Oct 2007 15:42:19 -0400
> "Andrew Paprocki" <andrew.m.paprocki@xxxxxxxxx> wrote:
>
> > Just noticed something.. I'm not sure if this is due to a libata-dev
> > change or me switching to pata_cs5536, but my 128MB DOM on the PATA
> > port is hitting the ata_dma_blacklisted() case and it was not
> > previously. This did not happen under 2.6.22.6 using pata_amd. The
> > system is noticeably slower when forced to use PIO4 (as you would
> > expect).
> >
> > Is this expected in the newer code, or is it a bug?
>
> Sounds like someone added it wrongly to the blacklist. Remove the
> blacklist entry, test again and if DMA is working we need to get that
> fixed ASAP in .2 and 2.6.24.
>
> Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux