On Wed, 03 Oct 2007 16:29:58 -0400 Jeff Garzik <jeff@xxxxxxxxxx> wrote: > akpm@xxxxxxxxxxxxxxxxxxxx wrote: > > From: Alan Cox <alan@xxxxxxxxxx> > > > > This patch assumes the mode filter patches were applied, if not then ping > > me and I'll send the trivially different patch (extra argument to > > mode_filter) > > > > Don't assume the BIOS can validate modes or has any sense at all. Instead use > > the BIOS timings to deduce the modes. > > > > Signed-off-by: Alan Cox <alan@xxxxxxxxxx> > > Cc: Tejun Heo <htejun@xxxxxxxxx> > > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > --- > > > > drivers/ata/Kconfig | 9 > > drivers/ata/Makefile | 2 > > drivers/ata/pata_acpi.c | 403 ++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 414 insertions(+) > > Can I get a better email subject and patch description please? > > Just reply to this email, and I can hand-edit the patch from there. > > "pata_acpi: restore driver" is a bad one-line summary, because nothing > was lost (hence nothing to be restored). it's simply a new driver. > > The patch description is also wanting -- it describes work-in-progress, > but should really be a summary of what the pata_acpi driver is, why we > want it, and how it works. > > Email some text, and I shall apply straightaway On a cable there may be eighty wires or perhaps forty and we learn about its type In the world of ACPI So we call the GTM And we find the the timing rate And we look through it to see If eighty wire it must be Timing lives in ACPI routines ACPI routines, ACPI routines Timing lives in ACPI routines ACPI routes ACPI routines And the drivers call into see Which cable type its to be And the code begins to work Timing lives in ACPI routines ACPI routines, ACPI routines Timing lives in ACPI routines ACPI routes ACPI routines [Full speed ahead, Mr Hacker, full speed ahead] Full speed over here sir! Checking Cable, checking cable Aye aye, 80 wire, Heaven heaven] If we use ACPI (ACPI) Every box (every box) has all we need (has all we need) Cable type (cable type) and mode timing (mode timing) In our ATA (in our ATA) subroutines (subroutines, ha ha) Timing lives in ACPI routines ACPI routines, ACPI routines Timing lives in ACPI routines ACPI routes ACPI routines Timing lives in ACPI routines ACPI routines, ACPI routines Timing lives in ACPI routines ACPI routes ACPI routines - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
