Re: [PATCH 2/2] libata: change the last state of pio read to HSM_ST_IDLE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
> Albert Lee wrote:
> 
>> Patch 2/2:
>>   After reading the last pio data block, the HSM is waiting for device
>> to be idle, not waiting for the last interrupt.
>>
>> This patch changes the state after "PIO data-in" to HSM_ST_IDLE instead
>> of HSM_ST_LAST for accuracy.
>>
>> Signed-off-by: Albert Lee <albertcc@xxxxxxxxxx>
> 
> 
> Is this still needed?
> 

Not quite needed; it only makes the state transition after reading the
last PIO block more accurate.

However, if we want to do part of the irq PIO in the workqueue sometime
in the future, this patch will be needed (otherwise the HSM might think
it expecting another irq). For the time being, maybe we can just skip
this patch until sometime it's really needed.
--
albert


 


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux