Re: [PATCH 9/15] cs5530: remove needless ide_lock taking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 02 October 2007, Alan Cox wrote:
> > -	spin_lock_irqsave(&ide_lock, flags);
> > -		/* all CPUs (there should only be one CPU with this chipset) */
> > -
> 
> NAK
> 
> What about pre-emptible kernels. Put in a private lock.

All the removed code resided in init_chipset_cs5530() which is called only
during the controller initialization.  Moreover pata_cs5530 also don't have
any locking in cs5530_init_chip().

Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux