On Wed, 26 Sep 2007 10:33:28 -0400 Jeff Garzik <jeff@xxxxxxxxxx> wrote: > Alan Cox wrote: > >>> NAK - mmio is an iomap so writel and readl are the wrong things to use > >> The patch is consistent with the rest of the driver. > >> You are welcome to submit a patch to convert ahci to using ioremap. > > > > You could just flip the relevant function to use ioread while you are > > tidying it up, instead of spreading new bugs into the code. > > No, as I just noted above, the proper fix for this driver is to use > ioremap rather than pci_iomap. > > Adding support to ahci for legacy PIO is completely pointless. iomap isn't just for legacy PIO. It allows us to handle future weird mappings in ways ioremap cannot. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
