Davide Libenzi wrote:
> On Tue, 25 Sep 2007, roel wrote:
>
>>> + if (!(ap->flags & ATA_FLAG_IPM) || !ata_dev_enabled(dev)) {
>> if (!((ap->flags & ATA_FLAG_IPM) && ata_dev_enabled(dev))) {
>
> int foo(int i, int j) {
>
> return !(i & 8) || !j;
> }
>
> int moo(int i, int j) {
>
> return !((i & 8) && j);
> }
>
>
> gcc -O2 -S:
>
>
> .globl foo
> .type foo, @function
> foo:
> shrl $3, %edi
> xorl $1, %edi
> testl %esi, %esi
> sete %al
> orl %eax, %edi
> andl $1, %edi
> movl %edi, %eax
> ret
> .globl moo
> .type moo, @function
> moo:
> shrl $3, %edi
> xorl $1, %edi
> testl %esi, %esi
> sete %al
> orl %eax, %edi
> andl $1, %edi
> movl %edi, %eax
> ret
Indeed, no difference, except for the eye.
do you not consider it an improvement or do you not want to change it?
or
don't you consider it an improvement and want to change it?
Never mind. Disregard if you please.
> - Davide
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
