On Tue, 25 Sep 2007 01:12:32 +0200 roel <12o3l@xxxxxxxxxx> wrote: > > #define ata_id_cdb_intr(id) (((id)[0] & 0x60) == 0x20) > > +#define ata_id_has_hipm(id) \ > > + ( (((id)[76] != 0x0000) && ((id)[76] != 0xffff)) && \ > > + ((id)[76] & (1 << 9)) ) > ^ > | > are you sure this > should be 76? Yes. > > we can also change the first statement a bit: > (!(((id)[76] == 0x0000) || ((id)[76] == 0xffff)) && \ > > > > +#define ata_id_has_dipm(id) \ > > + ( (((id)[76] != 0x0000) && ((id)[76] != 0xffff)) && \ > > and: > (!(((id)[76] == 0x0000) || ((id)[76] == 0xffff)) && \ I feel this is equivalent functionality and not as readable. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
