On Monday 24 September 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
[...]
> > @@ -783,6 +783,23 @@ int ide_tune_dma(ide_drive_t *drive)
> >
> > EXPORT_SYMBOL_GPL(ide_tune_dma);
>
> You're converting it to static and yet leaving exportable -- what for?
Oversight, export should be removed (already spotted/fixed by Adrian).
> > Index: b/drivers/ide/ide-probe.c
> > ===================================================================
> > --- a/drivers/ide/ide-probe.c
> > +++ b/drivers/ide/ide-probe.c
> > @@ -844,7 +844,7 @@ static void probe_hwif(ide_hwif_t *hwif,
> > * Move here to prevent module loading clashing.
> > */
> > // drive->autodma = hwif->autodma;
>
> I hope this gets killed by the "autodma" patch?
Yep.
> > Index: b/drivers/ide/pci/hpt34x.c
> > ===================================================================
> > --- a/drivers/ide/pci/hpt34x.c
> > +++ b/drivers/ide/pci/hpt34x.c
> > @@ -80,16 +80,6 @@ static void hpt34x_set_pio_mode(ide_driv
> > hpt34x_set_mode(drive, XFER_PIO_0 + pio);
> > }
> >
> > -static int hpt34x_config_drive_xfer_rate (ide_drive_t *drive)
> > -{
> > - if (ide_tune_dma(drive))
> > - return -1;
>
> Hm, why -1 in this driver and 0 in all the others? Looks like a
> functionality change?..
-1 is wrong (commit 76e1faa7cfd464fa06a9c2cafd633d643daafeae is to blame),
not a big issue since according to Alan this driver is broken ATM
I'll address this in "pre-patch".
Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
