Re: AMD64 dma_alloc_coherent crashes on non PCI device (was SATA open bugs) II

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> writes:

> > BTW unless I'm misreading the i386 code it'll not fail here, but
> > allocate memory. Surely that will cause failures later if you
> > rely on it failing? If you don't rely on it then changing x86-64
> > will also not help you.
> 
> Eww that'll do strange things.
> 

In theory I could change i386 too to return NULL in this case (dma_mask == NULL).
But I wonder how how many existing PCMCIA drivers I would break this way? 

Probably needs more testing at least.

My current patch is in 
ftp://ftp.firstfloor.org/pub/ak/x86_64/late-merge/patches/dma-alloc-mask

> Ok so we do in fact need some kind of proper way to ask if a device is
> DMA capable ?

Right now it seems to be (dev->dma_mask != NULL) 

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux