On Tue, 07 Aug 2007 11:47:38 -0400
Jeff Garzik <jeff@xxxxxxxxxx> wrote:
> People should check out Ben C's HPA fixes and cleanups, too. (attached)
>
> I was hoping one of the original libata HPA authors would review that in
> depth and integrate. (it no longer applies cleanly)
Looks basically sound but we should still probably move over this bit of
the old IDE paranoia as well:
/*
* Bits 10 of command_set_1 and cfs_enable_1 must be equal,
* so on non-buggy drives we need test only one.
* However, we should also check whether these fields are valid.
*/
static inline int idedisk_supports_hpa(const struct hd_driveid *id)
{
return (id->command_set_1 & 0x0400) && (id->cfs_enable_1 &0x0400); }
---
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
