On Tue, 7 Aug 2007 14:42:50 +0900 Tejun Heo <htejun@xxxxxxxxx> wrote: > HDS724040KLSA80 reports that it supports HPA && LBA48 but craps itself > on READ_NATIVE_MAX_EXT. Implement BROKEN_HPA horkage and apply it to > the drive. If the horkage is set, all HPA operations are skipped. I'd rather know what is going on here. A drive can legitimately support LBA48 and HPA and refuse READ_NATIVE_MAX_EXT. In addition just about every OS I know queries the HPA which means that something other than HPA support being broken is probably at the root. We thus want to find the real fix. What do the actual traces look like ? Does it crap out of it gets READ_NATIVE_MAX ? > > While at it, make HPA test a bit more reliable by also checking > ata_id_has_hpa(). > > - if (ata_id_hpa_enabled(dev->id)) > + if (!(dev->horkage & ATA_HORKAGE_BROKEN_HPA) && > + ata_id_has_hpa(id) && ata_id_hpa_enabled(dev->id)) > dev->n_sectors = ata_hpa_resize(dev); A drive cannot set hpa_enabled without setting has_hpa so this does nothing and I've never seen a drive d what you try to cover here. I'd like to see actual evidence. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
