> > > + dev->pio_mode <= XFER_PIO_2) > > Overindented line (to my taste :-). And do we really need to check this? > Yes - if it refuses SET_XFER_MODE we really don't want to run any mode above PIO2. No hardware *should* do this but then this is IDE... - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html