Tejun Heo wrote:
+ /* Some braindamaged ACPI suspend implementations expect the
+ * controller to be awake on entry; otherwise, it burns cpu
+ * cycles and power trying to do something to the sleeping
+ * beauty.
+ */
applied 1-2... HOWEVER...
I would not classify this as braindead. I have applied these patches,
but it must be emphasized that this is a temporary fix only.
Overall, it is unfortunately but libata must be aware of the state the
controller should be in, for suspend and resume. I bet some more
suspend/resume problems can be isolated to a hardware state mismatch,
where BIOS expects one thing but Linux has configured the hardware
differently.
A more generalized rule to consider for the future would be to ensure
that ALL suspend routines put the hardware back into its pre-Linux init
mode before suspending. i.e. that means if we turned on some enhanced
mode, we must switch back to legacy mode before calling pci_xxx to
suspend our device.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
