Re: [PATCH 2/11] ide-pmac: pmac_ide_tune_chipset() fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday 22 July 2007, Benjamin Herrenschmidt wrote:
> On Sun, 2007-07-22 at 20:21 +0200, Bartlomiej Zolnierkiewicz wrote:
> > * Don't check check for pmif == NULL (it should never be NULL if we got here).
> > 
> > * Make a local copy of the timings and set the pmif->timings[] only after
> >   setting the transfer mode on the device (otherwise SELECT_DRIVE() call in
> >   pmac_ide_do_setfeature() will program new timings before the transfer mode
> >   is set on the device - this was pointed out by Sergei).  This change makes
> >   pmac_ide_tune_chipset() behavior match this of pmac_ide_{m,u}dma_enable().
> > 
> 
> Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

added
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux