Re: [PATCH 5/11] ide-pmac: remove pmac_ide_{m,u}dma_enable()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>  static int
>  pmac_ide_dma_check(ide_drive_t *drive)
>  {
> -	struct hd_driveid *id = drive->id;

Actually, this one breaks compile, "id" is used a bit further below in
that function.

Cheers,
Ben.

> -	ide_hwif_t *hwif = HWIF(drive);
> -	pmac_ide_hwif_t* pmif = (pmac_ide_hwif_t *)hwif->hwif_data;
>  	int enable = 1;
> -	int map;
>  	drive->using_dma = 0;
>  	
>  	if (drive->media == ide_floppy)
> @@ -1780,13 +1688,8 @@ pmac_ide_dma_check(ide_drive_t *drive)
>  	if (enable) {
>  		u8 mode = ide_max_dma_mode(drive);
>  
> -		if (mode >= XFER_UDMA_0)
> -			drive->using_dma = pmac_ide_udma_enable(drive, mode);
> -		else if (mode >= XFER_MW_DMA_0)
> -			drive->using_dma = pmac_ide_mdma_enable(drive, mode);
> -
> -		/* Apply settings to controller */
> -		pmac_ide_do_update_timings(drive);
> +		if (mode && pmac_ide_tune_chipset(drive, mode) == 0)
> +			drive->using_dma = 1;
>  	}
>  	return 0;
>  }

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux