Re: [PATCH] Unbreak build of PMP with ACPI disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[cc'ing Jeff and Albert]

Petr Vandrovec wrote:
> Fix reported task file values in sense data
> 
> ata_tf_read was setting HOB bit when lba48 command was submitted, but
> was not clearing it before reading "normal" data.  Maybe it would be
> better to just clear HOB bit immediately after reading upper halves
> for lba48 command, but I just decided to clear HOB bit in each
> ata_tf_read...
> 
> Signed-off-by: Petr Vandrovec <petr@xxxxxxxxxxxxxx>

Acked-by: Tejun Heo <htejun@xxxxxxxxx>

Gee, thanks a lot for spotting this.  This is definitely for -stable.
Hmm... it's a separate issue and not your fault but ap->last_ctl caching
is broken in the function.  Albert is about to remove ap->last_ctl
caching but we still need to fix it for -stable.  Petr, are you
interested in submitting a separate patch for fixing ap->last_ctl
handling in the function?

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux