Hello. Bartlomiej Zolnierkiewicz wrote:
* Add setting transfer mode on the device to pmac_ide_set_pio_mode().
* Fix pmac_ide_set_pio() to always program chipset for given PIO timing instead of only when the device we want to program PIO timing for is the currently selected one.
Hm, why this was necessary?
No idea...
I may understand why this was needed beore the patch but why keep it?
...(mis)optimization? :)
AFAIU, pmac_ide_do_setfeature() will cause selectproc() to be called anyway, via SELECT_DRIVE()...
Yes, but pmac_ide_do_setfeature() wasn't called et all in the old version of pmac_ide_set_pio().
But now it is.
* Now that pmac_ide_set_pio() is fixed there is no need to set transfer mode on the device and program chipset for PIO in pmac_ide_tune_chipset()
BTW, I'm also not seeing much sense in calling pmac_ide_do_update_timings() from there as well since pmac_ide_do_setfeature() is called before that anyway.
The patch only intended to make pmac_ide_set_pio() match the code in pmac_ide_tune_chipset(). Thanks to your analysis I see now that more fixups/cleanups are possible in this driver but I'm not up to it...
:-) MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
