On Friday 13 July 2007, Russell King wrote: > On Fri, Jul 13, 2007 at 11:02:03PM +0200, Bartlomiej Zolnierkiewicz wrote: > > weeeeee, take 3 > > I'm probably going to drop this driver as soon as the PATA people get > their finger(s) out and respond to the issues I raised when merging > the pata_icside driver. > > > v3: > > * Remove no longer needed initialization/checking of cycle_time > > (Noticed by Sergei). > > > > * No need to set drive->drive_data if DMA is not going to be used > > (Noticed by Sergei). > > > > * Remove incorrect setting of drive->current_speed > > (Noticed by Sergei). > > > > * Move ide_config_drive_speed() at the end of icside_set_speed(). > > What happens if we set a DMA mode but ide_config_drive_speed() > fails? Wouldn't we set drive_data to the timing for that mode > and start to use it for future DMA accesses? If ide_config_drive_speed() fails then icside_dma_check() also fails so IDE core doesn't enable DMA. Therefore we never start DMA engine and icside_dma_setup() (the only place which reads drive->drive_data) is never called. Thanks, Bart - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
