Re: [PATCH 0/10] libata: irq_on/off restructuring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tejun Heo wrote:
 > 
> I like the whole series.  Just a few nits.
> 
> * 9 and 10 need to be oen patch.  As it currently stands, compile will
> fail after 9.
> 
> * Please don't include "Patch n/10" in message body.
> 
> * Add freeze/thaw to all, merge, kill freeze/thaw from all sequence is a
> bit odd.  It would be better if we can do things more directly but I
> haven't thought about how that can be done too hard, so if it's too
> difficult, it's probably not worth it.
> 
> Alan, Jeff, I think we'll need to do what IDE has been doing for IRQ
> masking to get acceptable PIO behavior after all and that will also make
> us more resistant against deadly IRQ storms on controllers which don't
> have pending IRQ bits (most SFF ones), and this change will ease our way
> toward that direction.  What do you guys think?
> 

Thanks for the review/advice. Revised patches to follow.
--
albert

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux