Re: [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
> Alan Cox wrote:
>>> but IDE simply ignores the error and continues to operate in MWDMA
>>> mode, so I guess we can remove the 'temporary fix' comment or add
>>> another quirk type - ATA_HORKAGE_SETXFER_MAY_FAIL - and use it.
>>
>> Should we warn in these cases ? Or issue a new identify and check the
>> mode activated ?
> 
> The latter, issuing a new identify, is really what you want to do.
> AFAICT that's the canonical method of querying the device's knowledge of
> its mode settings.

How about just keep using PIO as the patch posted in this thread does?
I'm not really sure adding more complexity is worth it considering it's
only one device till now and it may not even be safe considering that
some controllers snoop SETXFER and configure themselves accordingly.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux