Well, let's put the class code as "native" since the chip is made "native", in a platform file somewhere. Then, we can have a configuration option in the platform code which allows users to choose whether the IDE configuration is reworked to steer to a single IRQ or two IRQs. That way they can choose which driver they are using (they cannot use both, and compiling in both is stupid, so..) Then pata_via can just work. It does seem easier now to do this in the platform support thing. As long as it only affects brand new kernels and is only enabled when libata pata_via is enabled (we can make it depend on it) then it should work fine, although having it in some other config page seems pretty quirky. I don't know how you would suggest to do it.. have CONFIG_FIX_PEGASOS_IDE in drivers/ata/Kconfig and code in arch/powerpc/platforms/chrp which recognises it? This patch idea has to get past two teams now, though.. and modifying chip registers that early in CHRP initialisation seems to be quirky in itself (I don't think PCI is up yet) :D -- Matt Sealey <matt@xxxxxxxxxxxxxx> Genesi, Manager, Developer Relations Alan Cox wrote: > On Tue, 03 Jul 2007 14:41:55 +0100 > Matt Sealey <matt@xxxxxxxxxxxxxx> wrote: > >> The chip isn't in legacy mode. We never set it to legacy mode. Legacy mode would not work. >> It's set to native mode. However the PCI class code does not reflect this :) > > By the time the OS has booted to the point the IDE layer runs the PCI > class code has been read and pci->resource[] arrays have been set up for > the legacy addresses not the PCI BAR ones. > > So with a current kernel at the point the pci header quirks run you can > load the PCI bar values back into the pci->resource[] array. The code is > designed to allow for this. Unfortunately libata then ignores the values > provided because some changes haven't been made that have been pending > for ages. I'll push the relevant trivial bits to Andrew today after > testing them > >> The old Via driver checked the host controller configuration space, rather >> than trust the PCI class code and the ATA specs, it seems? Well, you would >> know since you wrote it? > > Not those bits. > > The intended code flow is this > > pci probe > early quirk > class IDE legacy > Load the resources 0 to 3 specially > header quirk > > resource tree reserved > > libata > Use resource 0-3 for legacy or native > > Right now the last bit is using hardcoded numbers that need fixing up. > > Alan - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
