Patch 9/9: It seems ->irq_on and ->irq_off are now only wrapped by freeze()/thaw() and unused elsewhere. This patch - Remove ->irq_on and ->irq_off. - Rename ->freeze and ->thaw to irq_on() and irq_off() to be specific. Hopefully the LLDDs need to implement only one irq on/off by either host adapter masking, nIEN manipulation, or both or something else. No patch for this yet. Just some idea like below... diff -Nrup 09_freeze_thaw_pdc2027x/include/linux/libata.h 10_replace_irq_on_off/include/linux/libata.h --- 09_freeze_thaw_pdc2027x/include/linux/libata.h 2007-06-12 13:35:19.000000000 +0800 +++ 10_replace_irq_on_off/include/linux/libata.h 2007-06-15 11:43:47.000000000 +0800 @@ -591,15 +591,13 @@ struct ata_port_operations { */ void (*eng_timeout) (struct ata_port *ap); /* obsolete */ - void (*freeze) (struct ata_port *ap); - void (*thaw) (struct ata_port *ap); + u8 (*irq_on) (struct ata_port *); + u8 (*irq_off) (struct ata_port *); void (*error_handler) (struct ata_port *ap); void (*post_internal_cmd) (struct ata_queued_cmd *qc); irq_handler_t irq_handler; void (*irq_clear) (struct ata_port *); - u8 (*irq_on) (struct ata_port *); - u8 (*irq_off) (struct ata_port *); u8 (*irq_ack) (struct ata_port *ap, unsigned int chk_drq); u32 (*scr_read) (struct ata_port *ap, unsigned int sc_reg); - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html