How should I proceed. I can submit both patches: >> - exclude SiS180 from enable bit checking or >> - exclude MuTol ATA133 from enable bit checking with different >> error_handler. >> > > Been away but - SiS180 wants excluding anyway according to all the docs, > the MuToL does appear to be working correctly with enable bits and we've > got no failure cases in old/new IDE so leave it alone (for now anyway) > I have checked some SiS 5513 config spaces with ATA133 for the enable bits. In all cases Alans code would work. But I dont know why the necesary bits are set. May be the hardware is different to the documentation or the BIOS is setting these bits for compatibility issue. The change of the error handler for SiS180 is really needed. The change of the errorhandler for Pre ATA133 chips is not reasonable. The change of the errorhandler for SiS5513 ATA133 controller is not mandatory. My suggestion: exclude only the SiS180 from the enable bits. But i want to have an ok , or a vote for the other variant. Uwe - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
