On Fri, 25 May 2007 09:48:52 +0200 Uwe Koziolek <uwe.koziolek@xxxxxxx> wrote: > The sata_sis driver supports SATA and PATA ports. The broken support > of both types in one controller is fixed. > > the PATA-port of SiS180 controller does not support a drive present status > in the pci configspace like the other SiS PATA controllers, check skipped. > > Signed-off-by: Uwe Koziolek <uwe.koziolek@xxxxxxx> Needs checking with SiS because they submitted code that uses those enable bits and its been in drivers/ide for years with respect of the MuTOL ATA133. No argument about the SATA one if you've checked the docs and seen the bug. > - if (!pci_test_config_bits(pdev, &sis_enable_bits[ap->port_no])) > + if ((pdev->device != 0x0180) && (pdev->device != 0x0181) && > + !pci_test_config_bits(pdev, &sis_enable_bits[ap->port_no])) > return -ENOENT; Might look a lot nicer with less brackets, or even better pull the device check out into a new static function (gcc will inline it all nicely anyway) so you can just say if (sis_enables_supported(pdev) && !pci_test... - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
